-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename mdc- prefixed tokens/variables to mat- #30677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to ship with a schematic?
Edit: Nevermind, just read the description. LGTM!
Yeah just a simple find-and-replace for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This didn't result in any name collisions? I'm pleasantly surprised
3e4923c
to
b153a08
Compare
* refactor: rename mdc- prefixed tokens to mat- * refactor: repeat mdc tokens along with mat rename * refactor: include mdc prefix in icon button --------- Co-authored-by: Andrew Seguin <[email protected]>
BREAKING CHANGE:
--mdc-
are now prefixed with--mat-
. Stylesheets that directly define these variables should be automatically renamed with the update schematic. To avoid future breaking changes as variables may be renamed or removed, use theoverrides
API which will provide a safer abstraction along with token-name checks.